Skip to content

[feature] added temperature reading to esp32s3 - #5398

Merged
aykevl merged 2 commits into
tinygo-org:devfrom
Wikwoj0512:esp32s3-temperature
Jul 5, 2026
Merged

aykevl merged 2 commits into
tinygo-org:devfrom
Wikwoj0512:esp32s3-temperature

Conversation

@Wikwoj0512

Copy link
Copy Markdown
Contributor

No description provided.

@aykevl aykevl left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into src/machine/machine_esp32s3? I don't see a reason why this needs a separate file (we already have a whole load of files in the src/machine directory).

Other than that, LGTM.

@Wikwoj0512

Copy link
Copy Markdown
Contributor Author

@aykevl moved to machine_esp32s3.go

@aykevl
aykevl merged commit 2003881 into tinygo-org:dev Jul 5, 2026
20 checks passed
@aykevl

aykevl commented Jul 5, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants